[openib-general] OFED ipoib_8111_to_2_6_16.patch

[Or Gerlitz]

Michael S. Tsirkin wrote:
>>> It's a backport for kernels <= 2.6.16.

>> Can you please send (and add to OFED 1.2) a changelog comment explaining 
>> the problem and how it is solved in 2.6.17 and above ?!

>> We are looking on some code around ipoib_neigh_destructor() and friends 
>> and the changelog would really be of help to us.

> Try this
> git log -Sneigh_destructor -- include/net/neighbour.h

produced nothing on my net-2.6.20 git however browsing the git log i see 
this patch, is this the one you refer to?

also, having that at (my) hand does not remove the need that you will 
set a changelog/signature for the OFED ipoib related backport patch.

> commit c5ecd62c25400a3c6856e009f84257d5bd03f03b
> Author: Michael S. Tsirkin <mst at mellanox.co.il>
> Date:   Mon Mar 20 22:25:41 2006 -0800
> 
>     [NET]: Move destructor from neigh->ops to neigh_params
> 
>     struct neigh_ops currently has a destructor field, which no in-kernel
>     drivers outside of infiniband use.  The infiniband/ulp/ipoib in-tree
>     driver stashes some info in the neighbour structure (the results of
>     the second-stage lookup from ARP results to real link-level path), and
>     it uses neigh->ops->destructor to get a callback so it can clean up
>     this extra info when a neighbour is freed.  We've run into problems
>     with this: since the destructor is in an ops field that is shared
>     between neighbours that may belong to different net devices, there's
>     no way to set/clear it safely.
> 
>     The following patch moves this field to neigh_parms where it can be
>     safely set, together with its twin neigh_setup.  Two additional
>     patches in the patch series update ipoib to use this new interface.
> 
>     Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>
>     Signed-off-by: Roland Dreier <rolandd at cisco.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>