[openib-general] [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability

Michael S. Tsirkin mst at mellanox.co.il
Thu Jan 18 13:18:40 PST 2007


> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH/RFC 2.6.21] ehca: ehca_uverbs.c: refactor ehca_mmap() for better readability
> 
>  > Roland, please note that I applied the previous patches to
>  > your git tree for-2.6.21 before creating this patch. I also
>  > realized a compile issue with the patch from Michael T. in
>  > ehca_reqs.c regarding "return qp pointer in ib_wc". For this
>  > I'll send another patch.
> 
> Michael -- I didn't notice before but you do seem to have misread the
> ehca CQ polling code.  The ehca CQ poll operation doesn't actually
> have the qp pointer readily available -- unless I'm mistaken, ehca
> will have to do an expensive search by QPN in a hash table to get the
> qp pointer.  That doesn't seem acceptable for every CQ poll, so do you
> have any ideas of how to salvage this API change?

qpnum is actually only required from poll cq if srq is supported.
so ehca can just fill in NULL.


-- 
MST




More information about the general mailing list