[openib-general] [PATCH] ib_addr: Handle Ethernet neighbour updates during route resolution.

Or Gerlitz or.gerlitz at gmail.com
Wed Jan 24 10:34:48 PST 2007


On 1/24/07, Steve Wise <swise at opengridcomputing.com> wrote:
> Handle Ethernet neighbour updates during route resolution.

> The IWCM uses the ib_addr services to do route resolution (neighbour
> discovery in the IP world).  The ib_addr netevent callback routine,
> however, currently only acts on Inifininband neighbour updates.  It needs
> to act on ethernet neighbour updates as well.

> This patch just removes filtering on device type altogether and
> will trigger on any neighour updates where the nud_type is valid.
> This simplifies the code some.

OK, as I have mentioned in the past there is a check in the fast path
xmit code of IPoIB to verify that the neighbour we are using now to
xmit (skb->neigh) has not changed its HA address since the last time
IPoIB xmit-ed with it - that is that the GID in the struct
neighbous->ha is the same as the GID in struct ipoib_neigh.

Such a diff happens when the kernel is acting to gratitius arp - that
is a remote peer has changed its HW address (eg as of fail-over of an
IP address from one IPoIB NIC to another IPoIB NIC - eg with bonding).

>From this patch i understand that we can register to the neighbour
change event in IPoIB and eliminate the run time check !?!?!?

Or.




More information about the general mailing list