[openib-general] [PATCH 1/2] rdma_cm: add support to join IPOIB multicast groups

[Or Gerlitz]

Sean Hefty wrote:
> Add to the rdma_cm an IPOIB port space that allows interoperability with
> IPoIB multicast traffic.  Use of the RDMA_PS_IPOIB is limited to multicast
> join/leave.
> 
> Rename the RDMA_UD_QKEY to RDMA_UDP_QKEY to signify that the qkey is only
> used with the RDMA_PS_UDP port space.
> 
> Signed-off-by: Sean Hefty <sean.hefty at intel.com>
> ---
> This patch differs from those posted by Or by limiting the ipoib port space
> to multicast traffic only.

OK, Sean i have tested the two patches and things are working fine, that 
is I have changed my multicast app to use RDMA_PS_IPOIB instead of 
RDMA_PS_UDP and  I am now able to run it against itself and against 
ipoib in all the possibilities :
	tx-app   / rx-ipoib
	tx-ipoib / rx-app
	tx-app   / rx-app

this means that basically (*) you have my OK for pushing the mutlicast 
support to OFED 1.2 (again my thinking is that this is fine for upstream 
as well).

The only missing piece here, as we agreed yesterday is to allow using 
PS_IPOIB IDs for unicast traffic over librdmacm, i guess this should be
fairly simple to add.

However, as the code freeze deadline becomes closer, would you be able 
to implement and push this by the end of this week?

Basically, my thinking is that if have the code that allows PS_IPOIB to 
do unicast and you have both udaddy and mckey working in --both-- 
PS_IPOIB and PS_UDP modes - push that.

how does this sounds to you?

Or.