[ofa-general] [PATCH] fix flow of handling duplicate SIDR REQs

[Or Gerlitz]

On 7/2/07, Sean Hefty <mshefty at ichips.intel.com> wrote:
>
> > This seems to be solved with the below patch, however, i see that
> > for duplicate REQs the code is much more involved, which means i
> > might be over-simplifying here...
>
> I don't think you're over-simplifying.  The REQ handling seems more
> involved because the connected state machine is more complex.


OK

REQ handling deals with duplicate messages by waiting to set the cm id
> state.  We could do the same in the sidr req handler.


Can you clarify what "waiting to set the cm id state" means?


> Since we're in this part of the code, I'll create a patch to fix the
> 'todo' comment in this function, to ensure that both patches fit
> together cleanly.


Assuming you refer to "todo: reply with no match" in cm_sidr_req_handler,
what else
need to be added to the current code? is  it sending the REP with a
different status (ie not 2) or sending a REJ?

Or.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20070702/98f6e4ca/attachment.html>