[ofa-general] Re: [PATCH] mlx4: add device reset to Internal Error handling mechanism

[Roland Dreier]

 > This patch also disables the detection of Internal Errors via a device
 > interrupt, because we wish to avoid the complexity of supporting
 > two independent detection mechanisms.

OK, but...

 >  static irqreturn_t mlx4_catas_interrupt(int irq, void *dev_ptr)
 >  {
 > -	mlx4_handle_catas_err(dev_ptr);
 > +	/* disable handling catas errors via interrupt. */
 > +	/* We now handle them via polling.              */
 > +	/* mlx4_handle_catas_err(dev_ptr);              */

Why not just delete all the interrupt stuff completely?


For

 > +		mod_timer(&priv->catas_err.timer,
 > +			  jiffies + MLX4_CATAS_POLL_INTERVAL);

and

 > +	priv->catas_err.timer.expires  = jiffies + MLX4_CATAS_POLL_INTERVAL;

how about round_jiffies_relative(MLX4_CATAS_POLL_INTERVAL) instead?

 - R.