[ofa-general] Re: [PATCHv2] IB/mad: fix duplicated kernel thread name

Michael S. Tsirkin mst at dev.mellanox.co.il
Mon Jul 16 04:59:11 PDT 2007


> Quoting Or Gerlitz <ogerlitz at voltaire.com>:
> Subject: Re: [PATCHv2] IB/mad: fix duplicated kernel thread name
> 
> Michael S. Tsirkin wrote:
> >Make mad module use a single workqueue rather than a per-port
> >workqueue. This way, we'll have less clutter on systems with
> >a lot of ports.
> >Signed-off-by: Michael S. Tsirkin <mst at dev.mellanox.co.il>
> >Thinking about it, why would we *want* a per-port thread?
> >What do you guys think about the following?
> >As a bonus, this makes it easier to renice the mad thread
> >for people that want to do this.
> 
> Indeed, today the mad module creates thread per device port, and the cm 
> module creates thread per cpu, so if the system has 16 cores and two 
> hcas each with two ports, the IB stack would create 20 threads just for 
> the sake of the mad and cm modules... I also think it would be good if 
> the mad module would create one thread and the cm module as well.
> 
> Sean - does it make sense to you to change the CM for that matter?
> 
> I brought below listing of the kernel threads on an rh4 u3 / ofed 1.2 
> system.

Per-CPU threads like CM does might make sense since they improve data locality.

-- 
MST



More information about the general mailing list