[ofa-general] Re: [PATCH 1 of 2] mlx4: implement query-qp

Roland Dreier rdreier at cisco.com
Tue Jul 17 10:49:52 PDT 2007


 > Thanks for applying it.  I sent it to you as a patch to a patch because
 > I thought the change would be much more obvious to you this way.

OK, but I basically have to apply it by hand then.  I guess the best I
could do would be to revert the original patch but save a copy, apply
your patch to the patch, and then apply that patch.  Anyway it makes
things much more laborious.

 > Would you rather next time that I just send you an updated version of the original patch,
 > or should I send the fix as a patch to the code after the original patch has been applied?

Either way is fine, but an incremental patch is probably better
(especially because it makes the changes easiest to see).  And
especially in this case, where the original buggy patch was already
upstream, an incremental patch is definitely best.



More information about the general mailing list