[ofa-general] [PATCH] IB/mad: fix duplicated kernel thread name

[Or Gerlitz]

Roland Dreier wrote:
>  > the patch for itself only fixes a possible confusion created for the
>  > user as of two processes with the same name, however the discussion
>  > evolved to the question of how many threads should be used by the MAD
>  > and CM layers.
> 
> Is there any practical impact of two kernel threads with the same
> name, though?  I have tons of processes that all are "/bin/bash" on my
> box and it doesn't hurt too much.

yes.

When looking on the system for debug etc purposes since I know the mad 
layer uses thread per device/port, when there is a problem (eg 
starvation, crash, deadlock, you named it), its beneficial to know to 
which traffic flow its related, so the duplicate name creates confusion, 
thats all.

> The simplest way to make sure all the threads have unique names would
> seem to be just a private counter in the mad module that counts up,
> rather than trying to do device or port number.  Sticking in the last
> character of the device name is obviously too ugly.

OK, this seems quite simple to implement.

However, Michael have sent you a patch that changes the mad layer to use 
only one thread and I have raised the question that with the current 
code mad layer uses thread per device/port and the cm uses thread per 
cpu, is this really needed? what the correct path here?

Some discussion on that is going over this thread.

Or.