[ofa-general] Re: [PATCH 02/12 -Rev2] Changes to netdevice.h

[Krishna Kumar2]

Hi Patrick,

Krishna Kumar2/India/IBM wrote on 07/23/2007 08:27:53 AM:

> Hi Patrick,
>
> Patrick McHardy <kaber at trash.net> wrote on 07/22/2007 10:36:51 PM:
>
> > Krishna Kumar wrote:
> > > @@ -472,6 +474,9 @@ struct net_device
> > >     void         *priv;   /* pointer to private data   */
> > >     int         (*hard_start_xmit) (struct sk_buff *skb,
> > >                        struct net_device *dev);
> > > +   int         (*hard_start_xmit_batch) (struct net_device
> > > +                       *dev);
> > > +
> >
> >
> > Os this function really needed? Can't you just call hard_start_xmit
with
> > a NULL skb and have the driver use dev->blist?

> Probably not. I will see how to do it this way and get back to you.

I think this is a good idea and makes code everywhere simpler. I
will try this change and test to make sure it doesn't have any
negative impact. Will mostly send out rev3 tomorrow.

Thanks,

- KK