[ofa-general] Re: [PATCH} libmlx4: poll cq tail pointer

[Roland Dreier]

thanks, applied, and also the following for the kernel:

commit a4668873c7271c4b6c540d6c4e8891c24e8a1736
Author: Roland Dreier <rolandd at cisco.com>
Date:   Mon Jun 11 14:44:42 2007 -0700

    IB/mlx4: Fix handling of wq->tail for send completions
    
    Cast the increment added to wq->tail when send completions are
    processed to u16 to avoid using wrong values caused by standard
    integer promotions.
    
    The same bug was fixed in libmlx4 by Eli Cohen <eli at mellanox.co.il>.
    
    Signed-off-by: Roland Dreier <rolandd at cisco.com>

diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c
index b2a290c..048c527 100644
--- a/drivers/infiniband/hw/mlx4/cq.c
+++ b/drivers/infiniband/hw/mlx4/cq.c
@@ -354,7 +354,7 @@ static int mlx4_ib_poll_one(struct mlx4_ib_cq *cq,
 	if (is_send) {
 		wq = &(*cur_qp)->sq;
 		wqe_ctr = be16_to_cpu(cqe->wqe_index);
-		wq->tail += wqe_ctr - (u16) wq->tail;
+		wq->tail += (u16) (wqe_ctr - (u16) wq->tail);
 		wc->wr_id = wq->wrid[wq->tail & (wq->max - 1)];
 		++wq->tail;
 	} else if ((*cur_qp)->ibqp.srq) {