[ofa-general] Re: [PATCH 1/2] libibumad: fix partition support

Hal Rosenstock halr at voltaire.com
Fri Jun 15 15:23:00 PDT 2007


On Fri, 2007-06-15 at 18:11, Sean Hefty wrote:
> >How about if abi_version == 5, setting pkey_index to 0 regardless of
> >what is set ? Isn't that all that ABI v5 really supports ?
> 
> This is what ends up happening.  The problem is that the pkey_index is set to 0
> by the kernel code.  Nothing it passed down from userspace.  I added the warning
> to umad_set_pkey() to notify the user that the value that they're trying to set
> is ignored.

Oh, right. So the question is whether we want that error message over
and over again. Sorry for being slow...

Also, should the index requested be validated (within range) or is that
handled with some error coming back from the lower levels when this is
misspecified ?

-- Hal

> - Sean




More information about the general mailing list