[ofa-general] RE: [PATCH 1/2] libibumad: fix partition support

[Sean Hefty]

>> 1. It might be better if the ABI version 5 warning message for only
>> pkey_index 0 being supported comes out at umad_init time rather than
>> umad_set_pkey time so that the user is not swamped with these.
>
>The reason you need the message is because you made it a void, right?
>How about umad_set_pkey getting a port and returning success status?

umad_set_pkey returns an int.  With ABI 5, the call does nothing, always returns
success, and the callers ignore the return value.  The proposed change displays
a warning and returns a failure, but the callers still ignore the return value.
We can remove the warning message, but it was the warning message that clued me
in on the fact that the pkey was being set incorrectly...

- Sean