[ofa-general] Re: [PATCH] libmlx4: fix adjustments for minimum qp capabilities in mlx4_create_qp

Jack Morgenstein jackm at dev.mellanox.co.il
Sat Jun 23 23:00:16 PDT 2007


On Thursday 21 June 2007 23:17, Roland Dreier wrote:
> 
> align_queue_size() always returns at least 1 so I don't see why this matters.
> 
No, it doesn't:

from libmlx4/src/verbs.c:
static int align_queue_size(struct ibv_context *context, int size, int spare)
{
        int ret;

        /*
         * If someone asks for a 0-sized queue, presumably they're not
         * going to use it.  So don't mess with their size.
         */
        if (!size)
                return 0;

Note that if the requested size is zero, the function returns zero.

- Jack



More information about the general mailing list