[ofa-general] Re: [PATCH 24/28] IB/ipath - ipath_poll fixups and enhancements

[Arthur Jones]

hi roland, ...

On Thu, Jun 21, 2007 at 11:14:23AM -0700, Roland Dreier wrote:
>  > the port_rcvhdrttail_kvaddr is the kernel virtual address
>  > allocated in coherent memory where the header queue is updated
>  > by the chip.  we use volatile to make sure the compiler does
>  > not use stale data...
> 
> OK, fair enough, although it seems you may be missing some memory
> barriers to make sure you don't run into the CPU reordering accesses
> to the head/tail pointers.

i had a quick look at the patch and the surrounding
code and i did not catch the problem.  can you be a
little more specific about the suspect code?

thanks...

arthur