[ofa-general] Re: [PATCH] osm: Converting the the C++ code to C in osm_ucast_lash.c

[Michael S. Tsirkin]

> Quoting Hal Rosenstock <halr at voltaire.com>:
> Subject: Re: [PATCH] osm: Converting the the C++ code to C in osm_ucast_lash.c
> 
> On Tue, 2007-03-06 at 12:51, Jason Gunthorpe wrote:
> > On Tue, Mar 06, 2007 at 06:03:16PM +0200, Yevgeny Kliteynik wrote:
> > > Hi Hal.
> > > 
> > > Converting the the C++ code to C.
> > 
> > This is actually valid C99 code. This is the method that ISO
> > standardized in C99 to do dynamic stack allocations (alloca is not
> > an ISO C function).
> > 
> > Since it is now 2007 is there really still a desire to not use C99
> > features?
> 
> My guess is that the Windows compiler didn't like this though :-(

Usually it's just a question of using the proper compiler flags.
Please check.

In any case
1. Should say so in the log
2. Please don't apply to ofed branch, only bugfixes should go there

-- 
MST