[ofa-general] Re: [PATCH] ib_ipoib: fix race detaching from mcast group before attaching

Michael S. Tsirkin mst at dev.mellanox.co.il
Mon Mar 19 23:52:05 PDT 2007


> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH] ib_ipoib: fix race detaching from mcast group before attaching
> 
>  > The attach QP only occurs in the context of the multicast callback thread.
>  > ib_sa_free_multicast() blocks until the callback returns, which ensures that the
>  > detach check/call (which is now done after ib_sa_free_multicast) cannot race
>  > with the attach call.
> 
> OK, makes sense.  Do we have confirmation that this fixes the original
> problem?  If so I'll queue this up...

Yes, this appears to have fixed the race.

-- 
MST



More information about the general mailing list