[ofa-general] Re: Re: [PATCH] IB/umad: fix GRH handling

Michael S. Tsirkin mst at dev.mellanox.co.il
Fri Mar 23 08:28:22 PDT 2007


> Quoting Hal Rosenstock <halr at voltaire.com>:
> Subject: Re: Re: [PATCH] IB/umad: fix GRH handling
> 
> On Wed, 2007-03-21 at 18:22, Hal Rosenstock wrote:
> > On Wed, 2007-03-21 at 01:52, Sean Hefty wrote:
> > > >> Unfortunately, at least opensm cannot respond to SA queries issued from a
> > > >> remote subnet.  I'm not sure how much work this would take to fix, or if
> > > >> other SAs have this issue.  Hal briefly looked at the problems,
> > > >
> > > >FWIW, I'll be looking some more at these again.
> > > 
> > > I think the following patch corrects the GRH handling issues in ib_umad.
> > > (Tested loading of ib_umad module only, and not against openSM.)
> > 
> > It can't be tested against OpenSM right now.
> > 
> > > If this looks right,
> > 
> > It looks right to me. I'll need some time to take it out for a test
> > driver as some other issues need some work to exercise this.
> 
> I exercised this and it works fine. The received GRH information is now
> seen on the receive side of user MADs.
> 
> Can this be pushed for OFED 1.2 as well ?

Overall, looks safe.
If you want the fix in OFED 1.2, file a bug in the bugzilla.

But - is this patch going into 2.6.21? And if not, why does
it have to be in OFED 1.2?

-- 
MST



More information about the general mailing list