[ofa-general] Re: [PATCH] IB/core: Enhance SMI for switch support

[Roland Dreier]

 > None of the functions in smi.c follow your definition. 
 > 0 is used to say discard packet and 1 for completion up the stack.

 > So, I am not sure if reworking this one function with 3 return values buys
 > anything.

Good point, I didn't look closely at smi.c.  I think reworking all the
smi.c return values with explicit IB_SMI_DISCARD etc return values
would make the code much easier to understand.  Probably doing that as
a separate patch before adding the switch stuff would be a good idea.

 - R.