[ofa-general] Re: [PATCH] IB/core: Enhance SMI for switchsupport

Roland Dreier rdreier at cisco.com
Thu Mar 29 12:22:15 PDT 2007


 > I see what you are referring to now. That's true for the other routines
 > but unfortunately not this one.

OK, that makes the current status even more confusing.

 > Not sure what the one set of names would be: 
 > discard != local and process != send
 > 
 > Two sets of names (enums) could do it though.

Yes, if the two return values have distinct semantics then they should
be using separate enums to indicate that.

 > If this is what is to be done then it should be 2 patches with the first
 > preserving the current CA/router only support with the enums and the
 > second adding in switch SMI.

Please, let's do this now, since we're in the area.  If we don't clean
up the code now it will slip down the priority list again and probably
never get done.

 - R.



More information about the general mailing list