[ofa-general] Re: [PATCH 2/3] remove ib pkey gid and lmc cache

[Michael S. Tsirkin]

> Quoting Yosef Etigin <yosefe at voltaire.com>:
> Subject: [PATCH 2/3] remove ib pkey gid and lmc cache
> 
> Remove IB cache from core
> 
> * Remove pkey, gid, and lmc caches
> * Rewrite ib_find_gid and ib_find_pkey over blocking device queries 
> * Modify users of the cache to use these methods
> 
> 
> Signed-off-by: Yosef Etigin <yosefe at voltaire.com>
> ---
>  drivers/infiniband/core/cache.c         |  398 --------------------------------
>  include/rdma/ib_cache.h                 |  118 ---------
>  drivers/infiniband/core/Makefile        |    2 
>  drivers/infiniband/core/cm.c            |    8 
>  drivers/infiniband/core/cma.c           |    9 
>  drivers/infiniband/core/core_priv.h     |    3 
>  drivers/infiniband/core/device.c        |  143 ++++++++++-
>  drivers/infiniband/core/mad.c           |    5 
>  drivers/infiniband/core/multicast.c     |    3 
>  drivers/infiniband/core/sa_query.c      |    3 
>  drivers/infiniband/core/verbs.c         |    3 
>  drivers/infiniband/hw/mthca/mthca_av.c  |    3 
>  drivers/infiniband/hw/mthca/mthca_qp.c  |   10 
>  drivers/infiniband/ulp/ipoib/ipoib_cm.c |    3 
>  drivers/infiniband/ulp/ipoib/ipoib_ib.c |    2 
>  drivers/infiniband/ulp/srp/ib_srp.c     |    6 
>  include/rdma/ib_verbs.h                 |   37 ++
>  17 files changed, 196 insertions(+), 560 deletions(-)

I think this should be split in 2 as follow:

1. Implement ib_find_gid and ib_find_pkey over blocking device queries 
   + Modify core and ULPs to use these methods

This will already fix ipoib pkey bug you opened in bugzilla.
   
2. modify mthca to keep cache updated by snooping MAD, and remove the cache

Not really high priority.

-- 
MST