[ofa-general] Re: IPOIB CM (NOSRQ)[PATCH V3] patch for review

[Michael S. Tsirkin]

> > > +static int ipoib_cm_post_receive(struct net_device *dev, u64 id)
> > > +{
> > > +   struct ipoib_dev_priv *priv = netdev_priv(dev);
> > > +   int ret;
> > > +
> > > +   if (priv->cm.srq) 
> > > +      ret = post_receive_srq(dev, id);
> > > +   else 
> > > +      ret = post_receive_nosrq(dev, id);
> > > +
> > > +   return ret;
> > > +}
> > 
> > I think you can split this one now that srq/nonsrq completions are
> > handled separately.
> 
> I don't understand this commennt.

Since you now have 2 handle_wc routines for srq/nonsrq,
call the appropriate one directly. Generally, I think we can
get rid of if (srq) tests on data path.

-- 
MST