[ofa-general] [PATCH] IB/ipath -- shadow the gpio_mask register

Roland Dreier rdreier at cisco.com
Tue May 8 17:58:51 PDT 2007


 > GPIO interrupts which have the gpio_mask bits set are
 > no longer unlikely.  remove the unlikely annotation in
 > the interrupt handler and keep a shadow copy of the
 > gpio_mask register.

A better changelog would be appreciated here... I can see deleting the
unlikely() if it's no longer appropriate, but why keep a shadow copy
of the register?  Because this is now a hotter path and you want to
avoid the MMIO read?

 - R.



More information about the general mailing list