[ofa-general] Re: [PATCHv3 1/2] ipoib: handle pkey change events

[Michael S. Tsirkin]

OK. looks pretty good to me. One coding style violation I found:

> @@ -268,5 +265,9 @@ void ipoib_event(struct ib_event_handler
>  	    record->element.port_num == priv->port) {
>  		ipoib_dbg(priv, "Port state change event\n");
>  		queue_work(ipoib_workqueue, &priv->flush_task);
> +	} else if (record->event == IB_EVENT_PKEY_CHANGE &&
> +		record->element.port_num == priv->port) {
> +		ipoib_dbg(priv, "pkey change event on port:%d\n", priv->port);
> +		queue_work(ipoib_workqueue, &priv->pkey_event_task);
>  	}
>  }

This violates Breaking long lines rule again. Should be

> +	} else if (record->event == IB_EVENT_PKEY_CHANGE &&
> +		   record->element.port_num == priv->port) {
> +		ipoib_dbg(priv, "pkey change event on port:%d\n", priv->port);
> +		queue_work(ipoib_workqueue, &priv->pkey_event_task);
>  	}

-- 
MST