[ofa-general] Re: [PATCH TRIVIAL] opensm: make osm_node_destroy() static

Sasha Khapyorsky sashak at voltaire.com
Wed May 9 14:27:40 PDT 2007


On 09:16 Mon 07 May     , Hal Rosenstock wrote:
> On Sun, 2007-05-06 at 13:44, Sasha Khapyorsky wrote:
> > This makes locally used osm_node_destroy() function static
> > 
> > Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> 
> Thanks. Applied (to master only).
> 
> Isn't the same applicable for the other osm_xxx_destroy functions ?

Only for those osm_xxx objects which have dynamic
constructors/destructors osm_xxx_new() and osm_xxx_delete().

> If
> so, shouldn't they also be made static ?

Yes, good idea.

Sasha



More information about the general mailing list