[ofa-general] [PATCH] IB/ipath -- shadow the gpio_mask register

Roland Dreier rdreier at cisco.com
Wed May 9 20:02:35 PDT 2007


 > > A better changelog would be appreciated here... I can see deleting the
 > > unlikely() if it's no longer appropriate, but why keep a shadow copy
 > > of the register?  Because this is now a hotter path and you want to
 > > avoid the MMIO read?
 > 
 > exactly.  shall i add that and resend?

That would be great.  Also I'm wondering what changed to make this a
hotter path (just a reference to an earlier patch would be fine, or
you could be more explicit).

No rush because I'm traveling this week so I probably won't be able to
apply anything until Monday anyway.

 - R.



More information about the general mailing list