[ofa-general] [PATCH] mlx4: fix uninitialized spinlock for 32-bit architectures

Jack Morgenstein jackm at dev.mellanox.co.il
Sun May 13 07:18:23 PDT 2007


uar_lock spinlock was used in mlx4_ib_cq_arm without being
initialized (on 32-bit hosts, in 64-bit atomic writes).

Signed-off-by: Jack Morgenstein <jackm at dev.mellanox.co.il>

diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index 7959698..ad107f2 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -561,6 +561,7 @@ static void *mlx4_ib_add(struct mlx4_dev *dev)
 
 	spin_lock_init(&ibdev->sm_lock);
 	mutex_init(&ibdev->cap_mask_mutex);
+	MLX4_INIT_DOORBELL_LOCK(&ibdev->uar_lock);
 
 	if (ib_register_device(&ibdev->ib_dev))
 		goto err_map;



More information about the general mailing list