[ofa-general] [OpenSM][RFC] OpenSM Proposed Perf Manager

Sasha Khapyorsky sashak at voltaire.com
Mon May 14 11:24:00 PDT 2007


On 06:58 Mon 14 May     , Hal Rosenstock wrote:
> > > +
> > > +/**
> > > + * group port counters for ports into the nodes
> > > + */
> > > +typedef struct _osm_pc_node {
> > > +	cl_map_item_t  map_item; /* must be first */
> > > +	uint64_t       node_guid;
> > > +	osm_event_pc_t   *ports;
> > > +	uint8_t        num_ports;
> > > +} osm_pc_node_t;
> > 
> > Is it really needed to keep osm_pc_node_t nodes in separate db (qmap)?
> > Why not to reuse already existed maps in osm_subn_t (we could add
> > 'void *pm_data' or so field to osm_physp_t structure)?
> 
> My one concern would be evolving the PerfMgr. This is better now but is
> this better when the PerfMgr is separated from the SM functionality ? I
> know there are other things to untangle to get there.

PerfMgr "sweep" is based on discovered fabric topology structures
anyway. So what is a reason to duplicate nodes/ports qmaps?

Sasha



More information about the general mailing list