[ofa-general] [PATCH 13 of 17]: add LRO support

[Or Gerlitz]

Eli Cohen wrote:
>> Since you have posted the patch, I am asking you if it has any negative 
>> influence on packet forwarding.
>>
>> I am not asking you to test it or whether you tested it with forwarding.
>>
> 
> The answer is yes since I do not recalculate TCP checksum as I aggregate
> the SKBs so the kernel might forward the TCP segment as multiple IP
> packets but with wrong TCP checksum (which is that of the first
> aggregated packet) but not of the overall aggregated segment.

OK, thanks for this clarification.

Can you clarify if/how this patch is related to the "lro: Generic Large 
Receive Offload for TCP traffic" RFC sent on August this year to netdev 
(eg see http://lwn.net/Articles/244206) ?

Assuming LRO is a --pure software-- optimization, what's the rational to 
put its whole implementation in the ipoib driver and not divide it to 
general part implemented in the net core and per driver part implemented 
per device driver that wants to support LRO (if such second part is 
needed at all)?

If I am wrong and their is some LRO assistance from the connectX HW, 
what is it doing?

Or.