[ofa-general] Re: [PATCH] DAT 2.0 change to include extended event data with all builds.

[James Lentini]

This makes to me.

On Tue, 16 Oct 2007, Arlin Davis wrote:

> James,
> 
> Can you comment on the following patch to DAT v2.0. Do you see any 
> issues? If ok, I would like to get this accepted and rolled back 
> into the specification.
> 
> Thanks,
> 
> -arlin
> 
> 
> --
> Modify dat.h dat_event to include event_extension_data[8].
> Extend struct dat_event outside of extension build
> switch to enable non-extended applications to work
> with extended libraries. Otherwise, there is a potential
> for the event callee to write back too much event data
> and exceed callers non-extended event buffer.
> --
> 
> Signed-off by: Arlin Davis <ardavis at ichips.intel.com>
> 
> --- a/dat/include/dat/dat.h
> +++ b/dat/include/dat/dat.h
> @@ -944,9 +944,7 @@ typedef struct dat_event
>      DAT_EVENT_NUMBER            event_number;
>      DAT_EVD_HANDLE              evd_handle;
>      DAT_EVENT_DATA              event_data;
> -#ifdef DAT_EXTENSIONS
>      DAT_UINT64                  event_extension_data[8];
> -#endif /* DAT_EXTENSIONS */
>  } DAT_EVENT;
> 
>  /* Provider/registration info */
>