[ofa-general] [PATCH] IB/core - delete redundant check for DR SMP

[Hal Rosenstock]

On Wed, 2007-10-17 at 13:32 -0700, Sean Hefty wrote:
> Ralph Campbell wrote:
> > The function handle_outgoing_dr_smp() is only called if the
> > MAD to be sent is a directed route SMP.  Thus, the check for
> > IB_MGMT_CLASS_SUBN_DIRECTED_ROUTE is redundant.
> > 
> > Signed-off-by: Ralph Campbell <ralph.campbell at qlogic.com>
> 
> Acked-by: Sean Hefty <sean.hefty at intel.com>

Acked-by: Hal Rosenstock <hal at xsigo.com>

> > diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
> > index 6f42877..c483d6e 100644
> > --- a/drivers/infiniband/core/mad.c
> > +++ b/drivers/infiniband/core/mad.c
> > @@ -679,8 +679,7 @@ static int handle_outgoing_dr_smp(struct ib_mad_agent_private *mad_agent_priv,
> >  	struct ib_wc mad_wc;
> >  	struct ib_send_wr *send_wr = &mad_send_wr->send_wr;
> >  
> > -	if (device->node_type == RDMA_NODE_IB_SWITCH &&
> > -	    smp->mgmt_class == IB_MGMT_CLASS_SUBN_DIRECTED_ROUTE)
> > +	if (device->node_type == RDMA_NODE_IB_SWITCH)
> >  		port_num = send_wr->wr.ud.port_num;
> >  	else
> >  		port_num = mad_agent_priv->agent.port_num;
> > 
> > 
> > _______________________________________________
> > general mailing list
> > general at lists.openfabrics.org
> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> > 
> > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> > 
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general