[ofa-general] [PATCH V3] infiniband/core: Enable loopback ofDRSMP responses from userspace

Ralph Campbell ralph.campbell at qlogic.com
Fri Oct 19 09:26:38 PDT 2007


On Fri, 2007-10-19 at 09:19 -0700, Sean Hefty wrote:
> > This looks like it could be a problem, but it is not directly
> > related to the original patch; i.e. loop back of a DR SMP
> > response being sent from userspace.
> > 
> > I think you could probably combine the routines as you suggest
> > or call them both as is done to solve the original problem.
> > If you want to combine this change with the original patch
> > to make a more uniform change across both problems that
> > would be fine with me.  Hal, Sean, do you have an opinion?
> 
> I think Hal pointed this out, but the mad layer doesn't currently 
> support mixing DR and LID routed SMPs.  I would like patches to add/fix 
> that to be separate.
> 
> - Sean

I agree.  I just wanted to review the original patch enough to be
sure I understood the limitations. Now that my memory of DR SMPs
is refreshed, if one of us resubmits the V3 patch plus the ipath
change plus the extended description, I will ACK it.




More information about the general mailing list