[ofa-general] Re: [PATCH V2] osm: QoS - adding CPI:CapabilityMask2 and turning on QOS_SUPPORTED bit

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Sun Oct 21 07:25:22 PDT 2007


Sasha Khapyorsky wrote:
> On 11:44 Sun 21 Oct     , Yevgeny Kliteynik wrote:
>>>> +/****d* OpenSM: Base/OSM_CAP2_IS_QOS_SUPPORTED
>>>> +* Name
>>>> +*	OSM_CAP2_IS_QOS_SUPPORTED
>>>> +*
>>>> +* DESCRIPTION
>>>> +*	QoS is supported
>>>> +*
>>>> +* SYNOPSIS
>>>> +*/
>>>> +#define OSM_CAP2_IS_QOS_SUPPORTED (1 << 1)
>>> This one is IB specific. I guess it should be somewhere in ib_types.h.
>>  Not sure I'm following.
>>  How is it different from other capability bits here?
>>  For instance, why is it more "IB specific" than OSM_CAP_IS_MULTIPATH_SUP?
> 
> Good point, it is not more. I think all other IB spec constants should go
> to ib_types.h too.

OK, then we should move all these capability bits to
ib_types in a separate patch.

  -- Yevgeny

> Sasha
> 




More information about the general mailing list