[ofa-general] Re: [PATCH 4/4] [RFC] IPoIB/cm: Add connected mode support for devices without SRQs

[Pradeep Satyanarayana]

Roland Dreier wrote:
>  > Crud, I see a bug with that commit and non-SRQ:
>  > ipoib_cm_handle_tx_wc() does
>  > 
>  >        struct ipoib_cm_tx *tx = wc->qp->qp_context;
>  > 
>  > and there's no reason for wc->qp to be set if the HCA does not handle
>  > SRQs.  In fact there's no reason for wc->qp to be set for send
>  > completions in general.
> 
> Actually, I take that back.  Every driver seems to set wc->qp in all
> cases, so I guess it is safe to rely on that now.  (Which actually
> means that the table of RX QPs in the non-SRQ patch can be dropped so
> we make things dramatically simpler).

Yes, the rx_table was introduced when ehca did not set wc->qp. I know
that Joachim Fenkes submitted a fix for that. I will confirm if
that fix is already in this tree.

> 
> But that means I really have no idea what your bug is.  Could you say
> how you're running netperf so I can try to reproduce the crash?

Nothing fancy, I simply run "netperf -H < IP address> -l <seconds>"
I am using netperf 2.4.1 (I presume the version should not matter).

Pradeep