[ofa-general] Re: [PATCHv2] ibnetdiscover: Support Xsigo chassis grouping

[Sasha Khapyorsky]

On 15:38 Mon 17 Sep     , Hal Rosenstock wrote:
> On Tue, 2007-09-18 at 00:40 +0200, Sasha Khapyorsky wrote:
> > On 15:08 Mon 17 Sep     , Hal Rosenstock wrote:
> > > Hi Sasha,
> > > 
> > > On Mon, 2007-09-17 at 23:51 +0200, Sasha Khapyorsky wrote:
> > > > Hi Hal,
> > > > 
> > > > On 17:36 Thu 13 Sep     , Hal Rosenstock wrote:
> > > > > ibnetdiscover: Support Xsigo chassis grouping
> > > > > 
> > > > > I think this also fixes a bug with grouping of multiple non Voltaire
> > > > > chassis as well.
> > > > 
> > > > Could you provide more details about this bug. 
> > > 
> > > I found it because the Xsigo grouping is similar to the non Voltaire
> > > grouping and tested a multiple chassis case which did not work.
> > 
> > But what the bug is?
> 
> The bug was that with multiple non Voltaire chassis, it would display
> the chassis numbers (and some other basic information) and then list all
> the switches not organized by chassis number.
> 
> > > > Should this be a separate patch?
> > > 
> > > Is this really needed ? I have no way of testing this independently of
> > > the (other) Xsigo changes.
> > > 
> > > > > Note: this patch is against OFED 1.2
> > > > 
> > > > Hal, you know - the patches for master should be against master (I spent
> > > > some time).
> > > 
> > > Thanks. As you know, we are working with OFED 1.2.
> > 
> > But this patch targets master, not OFED 1.2. It is not something new -
> > the patches should be generated against branch they are targeted.
> 
> I know; in the future, I will endeavor to take the time to up rev the
> changes to the master.

Thanks.

Sasha