[ofa-general] Re: IPoIB CM (NOSRQ) [PATCH 1] review

[Sean Hefty]

> Would it be more appropriate that I rephrase it something along the lines ...
> "We will simply drop the packet and let the remote end handle the dropped packet"

Ok - this makes more sense to me.

>>>>> +    rx_ptr = priv->cm.rx_index_table[index];
>>>>> +    if (unlikely(!rx_ptr)) {
>>>>> +        ipoib_warn(priv, "Received packet from a connection "
>>>>> +               "that is going away. Hardware will handle it.\n");
>>>>> +        return;
>>>>> +    }
>> If this check can ever succeed, then it's also possible for rx_ptr to
>> reference the wrong connection.  rx_table[index] should not be freed
>> until all receives associated with that QP have been processed.
> 
> rx_index_table[index] is freed only in the stale task. So, that means
> all receives have been processed by this time.

Then it sounds like we can remove this check.

- Sean