[ofa-general] Re: [PATCH] AMSO1100: Add check for NULL reply_msg in c2_intr

[Tom Tucker]

On Fri, 2008-04-04 at 12:22 -0700, Roland Dreier wrote:
> > I don't think anyone has ever hit this bug, so it is a low priority in my view. I also noticed that
>  > if we refactored vq_wait_for_reply that we could combine a common 
>  > 
>  > if (!reply) {
>  > 	err = -ENOMEM;
>  > 	goto bail;
>  > }
>  > 
>  > construct by guaranteeing that reply is non-null if vq_wait_for_reply returns without
>  > an error. This patch, however, is much smaller. What do you think?
> 
> Well, now is a good time to merge either version of the fix.  Would be
> nice to kill off one of the Coverity issues so I'm happy to take this.
> 
> It's up to you how much effort you want to spend on this... the
> refactoring sounds nice but I think we're OK without it.
> 

I'm up to my eyeballs right now. If it's ok with you I'd say defer the
refactoring.

>  - R.