[ofa-general] [PATCH 3/4][v2] dapl: add provider vendor revisiondata in private data with reject

Davis, Arlin R arlin.r.davis at intel.com
Fri Apr 4 23:52:04 PDT 2008


 
>>Add 1 byte header containing provider/vendor major revision
>>to distinguish between consumer and non-consumer rejects.
>>Validate size of consumer reject privated data.
>
>Not saying this is a bad idea, but doesn't it break the 
>protocol with existing
>DAPL?  It also shifts all of the existing private data off by 
>a byte, which
>could result in odd data alignment.

If the cma/cm could guarantee that IB_CM_REJ_CONSUMER_DEFINED
is always an indication of true consumer called reject versus
abnormal termination then I would not need to add the provider
header in reject private data.

Anyway, private data delivery in rejects is new for DAT v2 
and exposed for the first time with this patch set. There
is no compatibility issue with existing DAPL because reject
private data has been ignored up until this point.

I will adjust for odd data alignment.

Thanks for the feedback,

-arlin 
. 



More information about the general mailing list