[ofa-general] Re: [PATCH] do not change itt endianness

Hal Rosenstock hrosenstock at xsigo.com
Tue Apr 15 07:21:59 PDT 2008


Erez,

On Tue, 2008-04-15 at 09:33 +0300, Erez Zilber wrote:
> Roland Dreier wrote:
> >  > -	itt = ntohl(hdr->itt);
> >  > +	itt = hdr->itt;
> >
> > This still gives the sparse warning
> >
> >     drivers/infiniband/ulp/iser/iser_initiator.c:419:6: warning: incorrect type in assignment (different base types)
> >     drivers/infiniband/ulp/iser/iser_initiator.c:419:6: expected unsigned int [unsigned] itt
> >     drivers/infiniband/ulp/iser/iser_initiator.c:419:6: got restricted unsigned int [usertype] itt
> >
> > I guess the two possibilities are to use get_itt() or use a __force cast
> > if you don't want the masking that get_itt() does.  Which is correct?
> >
> >  - R.
> >   
> 
> Roland,
> 
> If I just run 'make', I don't see the warning. What should I do in order
> to get the same warning that you get?

Try:
make C=1

Look at Documentation/sparse.txt

-- Hal

> Thanks,
> Erez
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general




More information about the general mailing list