[ofa-general] [PATCH] IB/core - reset to error state transition not allowed

Ralph Campbell ralph.campbell at qlogic.com
Wed Apr 23 10:43:03 PDT 2008


I was reviewing the QP state transition diagram in the IB 1.2.1
spec. and the code for qp_state_table[], and noticed that
the code allows a QP to be modified from IB_QPS_RESET to
IB_QPS_ERR whereas the notes for figure 124 (pg 457)
specifically says that this transition isn't allowed.

Signed-off-by: Ralph Campbell <ralph.campbell at qlogic.com>

diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c
index 0504208..379239f 100644
--- a/drivers/infiniband/core/verbs.c
+++ b/drivers/infiniband/core/verbs.c
@@ -317,7 +317,6 @@ static const struct {
 } qp_state_table[IB_QPS_ERR + 1][IB_QPS_ERR + 1] = {
 	[IB_QPS_RESET] = {
 		[IB_QPS_RESET] = { .valid = 1 },
-		[IB_QPS_ERR]   = { .valid = 1 },
 		[IB_QPS_INIT]  = {
 			.valid = 1,
 			.req_param = {





More information about the general mailing list