[ofa-general] RE: [PATCH v2] ib/core: fix for send multicast group send leave retry

Hefty, Sean sean.hefty at intel.com
Sun Aug 10 22:32:41 PDT 2008


> > @@ -542,7 +545,11 @@ static void leave_handler(int status, st
> > {
> >      struct mcast_group *group = context;
> >
> > -    mcast_work_handler(&group->work);
> > +    if (status && (group->retries > 0)) {
> > +            send_leave(group, group->leave_state);

I didn't catch this in my earlier response, but we should call mcast_work_handler() if send_leave() fails to make sure that we reset the group state back to idle and process any queued joins.

The rest of the changes look okay to me.

- Sean

(Sorry if this breaks threading.)



More information about the general mailing list