[ofa-general] Re: [PATCH] opensm/libvendor/Makefile.am: create symbolic link to osmvendor library

[Sasha Khapyorsky]

On 17:52 Wed 13 Aug     , Yevgeny Kliteynik wrote:
> Hi Sasha,
> 
> Creating a symbolic link to the vendor library that denotes
> which type of vendor it is. This is needed for ibutils/ibis.
> This instal-exec-hook (among many others) was removed
> by the following patch:
> http://lists.openfabrics.org/pipermail/general/2008-July/052742.html
> 
> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> ---
>  opensm/libvendor/Makefile.am |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/opensm/libvendor/Makefile.am b/opensm/libvendor/Makefile.am
> index f72dbbe..a6dd0b9 100644
> --- a/opensm/libvendor/Makefile.am
> +++ b/opensm/libvendor/Makefile.am
> @@ -88,3 +88,8 @@ libosmvendorinclude_HEADERS = $(HDRS)
> 
>  # headers are distributed as part of the include dir
>  EXTRA_DIST = $(srcdir)/libosmvendor.map $(srcdir)/libosmvendor.ver
> +
> +# Create a link to the installed vendor lib to
> +# mark the type of the vendor library
> +install-exec-hook:
> +	ln -sf $(DESTDIR)/$(libdir)/libosmvendor.so $(DESTDIR)/$(libdir)/libosmvendor_$(with_osmv).so

It creates some mess in $(libdir). Those links are never cleaned and
since only one libosmvendor.so can be installed there I don't see how
this could be helpful.

Also as far as I understand this link was used by ibis ./configure
script only in case of ibmgtsm. Assuming so there are couple of options
to solve it without making such junk links: to add --with-sim option to
ibis ./configure script, or just to create this link *only* in simulation
environment from ibmgtsim build script.

Sasha