[ofa-general] [PATCH] osmtest: fixing core dump (ofed_1_3)

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Wed Aug 27 00:04:20 PDT 2008


Hi Sasha,

As Matthias points out, the buffer that is used by
sprintf is too small. Looks like leading '0x' was
overlooked when the buffer length was calculated.

Please apply to OFED_1_3 branch only - you have already
cleaned up all the sprintf usage in the trunk.

Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
---
 opensm/osmtest/osmt_service.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/opensm/osmtest/osmt_service.c b/opensm/osmtest/osmt_service.c
index 6d377af..b5fea32 100644
--- a/opensm/osmtest/osmt_service.c
+++ b/opensm/osmtest/osmt_service.c
@@ -750,7 +750,7 @@ osmt_get_service_by_name_and_key(IN osmtest_t * const p_osmt,
 	OSM_LOG_ENTER(&p_osmt->log, osmt_get_service_by_name_and_key);

 	if (osm_log_is_active(&p_osmt->log, OSM_LOG_VERBOSE)) {
-		char buf_service_key[33];
+		char buf_service_key[35];

 		sprintf(buf_service_key,
 			"0x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x",
-- 
1.5.1.4




More information about the general mailing list