[ofa-general] [OpenSM][PATCH] Corrected incoherency in __osm_ftree_fabric_route_to_non_cns comments

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Wed Dec 17 06:31:59 PST 2008


Hi Nikolas,

Nicolas Morey Chaisemartin wrote:
> It seems to be that there is an error in the comment of 
> __osm_ftree_fabric_route_to_non_cns comments.
> It said the function was to be called with TRUE,FALSE parameters when it 
> was called with TRUE,TRUE.
> I'm just discovering the Ftree routing code so I may have misunderstood 
> something.
> 
> Anyway if I'm right, here's the patch!

You're right, there's some incoherency in the comments.
There were few bug fixes that weren't followed by the comments.
In fact, there are more errors in this comment.

Here's the fix:

Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
---
  opensm/opensm/osm_ucast_ftree.c |    8 ++++----
  1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/opensm/opensm/osm_ucast_ftree.c b/opensm/opensm/osm_ucast_ftree.c
index aa51d23..ebe6612 100644
--- a/opensm/opensm/osm_ucast_ftree.c
+++ b/opensm/opensm/osm_ucast_ftree.c
@@ -2462,11 +2462,11 @@ static void __osm_ftree_fabric_route_to_cns(IN ftree_fabric_t * p_ftree)
   *    foreach HCA non-CN port in fabric
   *       obtain the LID of the HCA port
   *       get switch that is connected to this HCA port
- *       set switch LFT(LID) to the port connecting to compute node
- *       call assign-down-going-port-by-ascending-up(TRUE,FALSE) on CURRENT switch
+ *       set switch LFT(LID) to the port connected to the HCA port
+ *       call assign-down-going-port-by-ascending-up(TRUE,TRUE) on the switch
   *
- * Routing to these HCAs is routing a REAL hca lid on SECONDARY path.
- * However, we do want to allow load-leveling of the traffic to the non-CNs,
+ * Routing to these HCAs is routing a REAL hca lid on MAIN path.
+ * We want to allow load-leveling of the traffic to the non-CNs,
   * because such nodes may include IO nodes with heavy usage
   *   - we should set fwd tables
   *   - we should update port counters
--
1.5.1.4




More information about the general mailing list