[ofa-general] [RDMA CM IPv6 PATCHv7 2/2] RDMA CM

[Roland Dreier]

Thanks, applied as well.

By the way (this goes for both patches, and I'm not sure how many times
I've written this to various people, but I'll write it one more time to
you), please don't put extraneous junk like:

 > >From 774a822be601135b438efe8a6c630b433db517c9 Mon Sep 17 00:00:00 2001
 > Date: Wed, 24 Dec 2008 15:27:36 +0200
 > Subject: [PATCH] RDMA CM IPv6 support

in the body of your email -- I just have to edit it out by hand to avoid
git importing into the kernel log forever.  The "From:" line is fine,
since git will use that as the author of the patch, except in your case,
you had

 > From: Aleksey Senin <aleksey at alst60.(none)>

and I think it's better for the author of the patch to have a more
reasonable email address, so I had to delete that by hand too.

A better subject line for the email would be good too.  Just having

> Subject: Re: [ofa-general] [RDMA CM IPv6 PATCHv7 2/2] RDMA CM

ends up putting "RDMA CM" in the kernel log after everything is
stripped, which is not really useful to someone looking at the shortlog
and trying to see what changed.  So I had to edit that by hand too.

Finally (and this may be too hard for some people who are not totally
comfortable with writing English), a better changelog would be good.  If
you just write:

 > AF_INET6 case in rdma_bind_addr added
 > AF_INET6 support in cma_format_hdr function
 > AF_INET6 support when checking loopback address
 > Use sockaddr_storage structure in cma_bind_any function

then all that shows is the details of what your patch changes, which I
can see just as easily by reading the patch.  A changelog should give
additional commentary, like what the high-level goal of your change is,
why we want to make that change, and any other information that would be
useful for someone trying to understand the change (possibly years in
the future).

 - R.