[ofa-general] Re: [PATCH]: mlx4: move table_find from fmr_alloc to fmr_enable

Roland Dreier rdreier at cisco.com
Thu Feb 14 10:48:19 PST 2008


by the way, it seems we never release ICM table entries when freeing
MPTs.  Does the patch below make sense to you?

diff --git a/drivers/net/mlx4/mr.c b/drivers/net/mlx4/mr.c
index 679dfdb..3ffce7a 100644
--- a/drivers/net/mlx4/mr.c
+++ b/drivers/net/mlx4/mr.c
@@ -287,6 +287,8 @@ void mlx4_mr_free(struct mlx4_dev *dev, struct mlx4_mr *mr)
 				     (dev->caps.num_mpts - 1));
 		if (err)
 			mlx4_warn(dev, "HW2SW_MPT failed (%d)\n", err);
+
+		mlx4_table_put(dev, &mr_table->dmpt_table, key_to_hw_index(mr->key));
 	}
 
 	mlx4_mtt_cleanup(dev, &mr->mtt);



More information about the general mailing list