[ofa-general] [PATCH] libibumad: umad_get_pkey() function

Sasha Khapyorsky sashak at voltaire.com
Mon Jan 14 14:50:19 PST 2008


On 09:47 Mon 14 Jan     , Hal Rosenstock wrote:
> On Mon, 2008-01-14 at 09:26 -0800, Sean Hefty wrote:
> > >This returns value of pkey_index in network byte order from user_mad
> > 
> > Why would you return an index in network byte order?
> 
> Looking at the code, I think the description is wrong in terms of that
> and should remove the words "in network byte order" but the code looks
> right to me. In fact, it appears with new_user_api in umad_set_pkey that
> there was a bug (in the existing code) in that pkey_index was converted
> to network order.

Right, there was a bug there. And agree about wrong patch description, I
will change it.

Sasha



More information about the general mailing list