[ofa-general] [PATCH 14/16] ib/ipoib: Support modifying IPOIB CQ moderation params

[Eli Cohen]

On Mon, 2008-01-21 at 11:19 +0200, Or Gerlitz wrote:
> Eli Cohen wrote:
> > Thinking it over , if I want to make the code correct as it is now (e.g.
> > a single cq for both tx and rx), I must require that the user supply
> > both tx and rx values in each invocation of ethtool and that these
> > values be identical. Alternatively we can say that rx dictates
> > configuration for both rx and tx. When we get separate tx and rx CQs 
> > I will modify this patch to exclude tx configuration.
> 
> 
> my vote is for having the rx dictating the configuration and excluding 
> the tx handling, but if you want to have it now and remove it later, 
> that's fine.
> 
> Or.
> 
I also favor the idea of rx dictating the configuration - that's how it
is implemented currently.