[ofa-general] Re: [PATCH] opensm: osm_version.h not found

[Sasha Khapyorsky]

Hi Yevegeny,

On 13:47 Mon 28 Jan     , Yevgeny Kliteynik wrote:
> 
> When building OpenSM I get the following error messages:
> 
> 	cat: <my source dir>/../include/opensm/osm_version.h: No such file or directory
> 	/bin/sh: line 0: [: 3.1.8: unary operator expected

Interesting, how your build is activated (I'm not able to reproduce this
in any know conditions)?

> This error is not affecting the build itself - everything works fine.
> The following patch fixes this error.
> 
> I'm not sure if this applicable to ofed_1_3, but if it is, please
> apply both to master and to ofed_1_3.
> 
> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> ---
>  opensm/opensm/Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/opensm/opensm/Makefile.am b/opensm/opensm/Makefile.am
> index d617994..50fdae1 100644
> --- a/opensm/opensm/Makefile.am
> +++ b/opensm/opensm/Makefile.am
> @@ -105,7 +105,7 @@ opensminclude_HEADERS = $(srcdir)/../include/opensm/osm_base.h \
>  BUILT_SOURCES = osm_version
>  osm_version:
>  	if [ -x $(top_srcdir)/../gen_ver.sh ] ; then \
> -		ver_file=$(srcdir)/../include/opensm/osm_version.h ; \
> +		ver_file=$(top_builddir)/include/opensm/osm_version.h ; \

Isn't 'top_srcdir' would be better here?

Sasha


>  		osm_ver=`cat $$ver_file | sed -ne '/#define OSM_VERSION /s/^.*\"OpenSM \(.*\)\"$$/\1/p'` ; \
>  		ver=`$(top_srcdir)/../gen_ver.sh $(PACKAGE)` ; \
>  		if [ $$ver != $$osm_ver ] ; then \
> -- 
> 1.5.1.4
> 
>