[ofa-general] Re: [PATCH 4/16 v2] IB/ipoib: Add checksum offload support for ipoib

[Eli Cohen]

On Sun, 2008-01-27 at 14:51 +0200, Or Gerlitz wrote:
> Eli Cohen wrote:
> > --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> > +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
> > @@ -1234,6 +1234,11 @@ static ssize_t set_mode(struct device *d, struct device_attribute *attr,
> >  		set_bit(IPOIB_FLAG_ADMIN_CM, &priv->flags);
> >  		ipoib_warn(priv, "enabling connected mode "
> >  			   "will cause multicast packet drops\n");
> > +
> > +		dev->features &= ~NETIF_F_IP_CSUM;
> 
> if adding NETIF_F_IP_CSUM brings in NETIF_F_SG, why not ANDing here with 
> ~NETIF_F_SG as well?
> 
You're right - I will fix that.

> > +
> > +		priv->tx_wr.send_flags &= ~IB_SEND_IP_CSUM;
> 
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general